From the American Kennel Club:

Dear AKC: I have a 4-month-old German Shepherd Dog. She is wonderful, loving, sweet, and does all that she can to please. However, we have a big problem. She is peeing in her crate every night. I read that by 4 months this should stop – it hasn’t. She comes out in the morning “dripping wet”! I have tried various things but nothing is working. Suggestions? –Piddlin’ Puppy

Dear Piddlin: Housebreaking puppies is one of the most difficult tasks facing a new dog owner. Over the years I have had some puppies pick it up right away and others that took longer to control their bladders. There are a few tried and true things you can do to see if it makes a difference. A four-month-old puppy is still very young and unfortunately there is no magic number of months when accidents stop. It really depends on the dog, the breed and how diligent the owner is with consistent housetraining methods. A rule of thumb for “holding it” for puppies is to take the puppies age in months (so for your dog that is 4) and add 1 to estimate the number of hours that a puppy can hold it before she needs to go outside to potty. Right now 5 hours is her maximum. If you sleep for 8 hours and she gets up before you, then she will most likely have to pee and will do so in her crate. Read the rest at the American Kennel Club Website